Software for Liquid Argon time projection chambers
Step | Responsible role | Procedure | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Create/modify PR | User | Create a new pull request using hub or the GitHub GUI. Modify one using the GitHub GUI |
||||||||||||
Code checks | Level 2 manager | * Verify the user is authorized to commit code. If not, proceed to “reject PR” step * Review the code to verify compliance with plans, architecture, etc. If not compliant, proceed to “reject PR” step * Post “code-checks” comment to the PR to launch code checks a stand-alone build The CI system will run code checks and build. The FNALbuild account will post “+code-checks” if successful, “-code-checks” if it failed * If the code-checks failed, refer the PR back to the user for corrective actions, and proceed to the “reject PR” step * If the code-checks succeeded, proceed to the next step |
||||||||||||
Build and test | Level 2 manager | * Post the appropriate “trigger build” comment to the PR. See [[Pull_request_comments_that_trigger_CI_actions]] for more information The CI system will build the code against develop for all repositories and experiments, and run all unit and CI tests.The FNALbuild account will post “+tests” if successful, “-tests” for any failures. * If the build and test failed, refer the PR back to the user for corrective actions, and proceed to the “reject PR” step * If the build and test succeeded, proceed to the next step |
||||||||||||
Level 2 approval | Level 2 manager | * Post any of the following three comments: “+1” “+ “approved”</td> </tr> Approval to merge |
Level 1 manager |
* Post the comment “merge” to trigger a merge of the PR to the target branch |
Approval to close |
Level 1 manager |
* Post the comment “close” to trigger closing the PR |
Reject PR |
Level 1 or |
Level 2 manager A PR should be rejected if it should not or cannot be merged. Reasons could include no authorization, significant structural problems, changes not consistent on-going plans, etc. |
Remove approval |
Level 1 manager |
In rare instances, issues may be raised after approval has been granted. If the PR is not already merged, delete the comment or comments approving the PR and change the labels. This must all be done by hand. |
|